Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in upstream skeleton changes to fix pre-commit linting #386

Merged
merged 270 commits into from
Nov 25, 2024

Conversation

felddy
Copy link
Owner

@felddy felddy commented Nov 25, 2024

🗣 Description

This PR merges in changes from the skeleton repositories in an attempt to fix the pre-commit linter bit rot.
It also unpins testing dependencies to deal with a coverage incompatibility with Python 3.13.0.

💭 Motivation and context

Trying to get the system back up and running so I can support a v5 WeeWX container.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

mcdonnnj and others added 30 commits April 1, 2022 13:10
…es_for_github_actions

Add Dependabot ignore directives
…s/cache-3

Bump actions/cache from 2 to 3
Use Python 3.10 for the `lint` job in GitHub Actions
Add hooks to validate GitHub Actions and GitHub Action workflows. These
are validated using JSON Schemas.
…re-commit_hooks

Add `pre-commit` hooks to validate GitHub Actions content
Additionally as of v3.1.0 of actions/setup-go there is a go-version
output value to retrieve the version of Go installed by the Action.
This allows us to remove the step to manually retrieve this information
from the Go executable.
Go 1.16 is no longer supported as of the release of 1.18 so it makes
sense to update to the latest version available.
Uncomment the `github-actions` Dependabot ignore directives because
those dependencies are managed by cisagov/skeleton-generic upstream.
We must ensure that all `workflow_dispatch` input defaults are string
values. This ensures expected behavior instead of relying on automatic
type conversions.
This includes adding the versioned GitHub Actions that should be
ignored in downstream projects and a comment stating where these
dependencies are managed.
The "docker compose" syntax is the preferred (and only correct) syntax
after the changes in cisagov/ansible-role-docker#60.
Lineage pull request for: skeleton
…nores

Update Dependabot ignore directives
…_versions

Update GitHub Action versions for this project
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Update code to use the "docker compose" syntax vice "docker-compose"
Go 1.19 was released while this branch was in the wings and it makes
sense to bump to the latest Go release.
Update Go installation in the `build.yml` workflow
Bumps [hashicorp/setup-terraform](https://github.com/hashicorp/setup-terraform) from 1 to 2.
- [Release notes](https://github.com/hashicorp/setup-terraform/releases)
- [Changelog](https://github.com/hashicorp/setup-terraform/blob/main/CHANGELOG.md)
- [Commits](hashicorp/setup-terraform@v1...v2)

---
updated-dependencies:
- dependency-name: hashicorp/setup-terraform
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
mcdonnnj and others added 15 commits December 6, 2023 07:55
…_script

Enhance the functionality of the `bump_version.sh` script
…/login-action-3

Bump docker/login-action from 2 to 3
…/setup-buildx-action-3

Bump docker/setup-buildx-action from 2 to 3
…/setup-qemu-action-3

Bump docker/setup-qemu-action from 2 to 3
Bumps [actions/github-script](https://github.com/actions/github-script) from 6 to 7.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v6...v7)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4 to 5.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v4...v5)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
There is currently a potential incompatibility with the default
behavior of the version of buildx being used. A default image generated
is built with provenance, which is something we would like to have, but
these default images can run on neither Google Cloud Run nor AWS
Lambda. Please see docker/buildx#1533 for mroe information. Since we
want to retain support for creating AWS Lambda images we add a
commented out disabling of this functionality that can be enabled in a
downstream repository if needed.
…s/github-script-7

Bump actions/github-script from 6 to 7
…/build-push-action-5

Bump docker/build-push-action from 4 to 5
Caught by new hooks
Bumping versions for better platform / architecture support.

Disabling installation of libraries in preparation for v5.
@felddy felddy disabled auto-merge November 25, 2024 21:06
@felddy felddy merged commit 110c14f into develop Nov 25, 2024
25 of 27 checks passed
@felddy felddy deleted the update/pre-commit branch November 25, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants